Sidecar submitter contianer template#4477
Open
marosset wants to merge 5 commits intoray-project:masterfrom
Open
Sidecar submitter contianer template#4477marosset wants to merge 5 commits intoray-project:masterfrom
marosset wants to merge 5 commits intoray-project:masterfrom
Conversation
Signed-off-by: Mark Rossett <marosset@microsoft.com>
Signed-off-by: Mark Rossett <marosset@microsoft.com>
Signed-off-by: Mark Rossett <marosset@microsoft.com>
Signed-off-by: Mark Rossett <marosset@microsoft.com>
marosset
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
Signed-off-by: Mark Rossett <marosset@microsoft.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // pass the RayCluster instance for cluster selector case | ||
| func configureSubmitterContainer(container *corev1.Container, rayJobInstance *rayv1.RayJob, rayClusterInstance *rayv1.RayCluster, submissionMode rayv1.JobSubmissionMode) error { | ||
| // Always set the container name to the expected submitter container name | ||
| container.Name = utils.SubmitterContainerName |
There was a problem hiding this comment.
Container name overwrite affects K8sJobMode unexpectedly
Medium Severity
The new line container.Name = utils.SubmitterContainerName in configureSubmitterContainer always overwrites the container name, regardless of submission mode. This function is called for both K8sJobMode and SidecarMode. For K8sJobMode users with a custom SubmitterPodTemplate that specified a custom container name, their name will now be silently overwritten to "ray-job-submitter". This is an unintended side effect of the SidecarMode feature and could break existing K8sJobMode configurations.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These changes allow users to specify a container template to be used for submitter container when using Sidecar submission mode.
This functionality has been requested so sidecar submitter containers can specify volume mounts and/or env vars to be used during job ray job submission.
Related issue number
Fixes #4197
Checks